fix: HTTP Client errors mark session as errored #6633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically captured HTTP client errors now mark sessions as errored. Fixes GH-3742
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6633 +/- ##
=============================================
- Coverage 85.006% 84.983% -0.024%
=============================================
Files 452 452
Lines 27686 27690 +4
Branches 12157 12152 -5
=============================================
- Hits 23535 23532 -3
- Misses 4105 4114 +9
+ Partials 46 44 -2
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b44bf23 | 1214.60 ms | 1251.75 ms | 37.15 ms |
| b115f82 | 1212.96 ms | 1251.92 ms | 38.96 ms |
| 664c060 | 1215.48 ms | 1244.41 ms | 28.93 ms |
| 939d583 | 1209.96 ms | 1251.09 ms | 41.13 ms |
| f83dcc4 | 1210.88 ms | 1246.22 ms | 35.35 ms |
| f246093 | 1219.75 ms | 1247.35 ms | 27.60 ms |
| 7a8b167 | 1217.49 ms | 1247.67 ms | 30.18 ms |
| ea3f7b6 | 1228.14 ms | 1258.71 ms | 30.57 ms |
| f8cad3c | 1217.94 ms | 1257.96 ms | 40.02 ms |
| 9c75c11 | 1228.42 ms | 1262.81 ms | 34.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b44bf23 | 23.75 KiB | 1022.78 KiB | 999.03 KiB |
| b115f82 | 23.75 KiB | 989.04 KiB | 965.30 KiB |
| 664c060 | 23.74 KiB | 977.41 KiB | 953.67 KiB |
| 939d583 | 23.75 KiB | 1023.82 KiB | 1000.07 KiB |
| f83dcc4 | 23.75 KiB | 1.02 MiB | 1019.11 KiB |
| f246093 | 23.75 KiB | 1022.79 KiB | 999.04 KiB |
| 7a8b167 | 24.14 KiB | 1.01 MiB | 1014.00 KiB |
| ea3f7b6 | 23.75 KiB | 1.01 MiB | 1008.77 KiB |
| f8cad3c | 23.75 KiB | 1.01 MiB | 1016.13 KiB |
| 9c75c11 | 23.74 KiB | 1022.95 KiB | 999.20 KiB |
Previous results on branch: fix/client-error-session-error
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 26f6484 | 1214.64 ms | 1247.59 ms | 32.95 ms |
| 99ac7d1 | 1212.64 ms | 1237.16 ms | 24.52 ms |
| e886f08 | 1213.26 ms | 1242.90 ms | 29.64 ms |
| 016277f | 1218.59 ms | 1258.81 ms | 40.22 ms |
| f67de13 | 1212.63 ms | 1242.78 ms | 30.15 ms |
| f7802af | 1228.92 ms | 1259.16 ms | 30.24 ms |
| 23a141f | 1220.30 ms | 1253.12 ms | 32.82 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 26f6484 | 23.75 KiB | 1.00 MiB | 1001.02 KiB |
| 99ac7d1 | 23.75 KiB | 1.02 MiB | 1016.55 KiB |
| e886f08 | 23.75 KiB | 1.02 MiB | 1020.21 KiB |
| 016277f | 23.75 KiB | 1.00 MiB | 1001.09 KiB |
| f67de13 | 23.75 KiB | 1.00 MiB | 1001.01 KiB |
| f7802af | 23.75 KiB | 1.00 MiB | 1001.07 KiB |
| 23a141f | 23.75 KiB | 1.02 MiB | 1016.68 KiB |
philipphofmann
commented
Nov 3, 2025
philipphofmann
requested review from
itaybre,
noahsmartin and
philprime
as code owners
Member
Author
|
Failing UI tests will be fixed with #6650. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
Back to draft, because I'm trying to get rid of many NSBlocks. |
philipphofmann
added
the
ready-to-merge
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Automatically captured HTTP client errors now mark sessions as errored.
💡 Motivation and Context
Fixes GH-3742
💚 How did you test it?
Unit tests and manually capturing a HTTP client error via the sample app: https://sentry-sdks.sentry.io/explore/releases/philipp-test-client-errors%2B1.0.0/?issuesType=all&project=5428557
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.